Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.01] Fix up tox.ini #16567

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[22.01] Fix up tox.ini #16567

merged 1 commit into from
Aug 17, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 17, 2023

Implicit environments have been disallowed in the latest tox, so I've added unprefixed variants so we don't need to always include the py* prefix.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 22.05 milestone Aug 17, 2023
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 17, 2023

No, i think this is just a very old branch where we didn't apply previous fixes.

@mvdbeek mvdbeek merged commit 54c44b6 into galaxyproject:release_22.01 Aug 17, 2023
24 of 32 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@davelopez
Copy link
Contributor

Looks like we are still missing unit-coverage https://github.com/galaxyproject/galaxy/actions/runs/5889422770/job/15974717957?pr=16561
But it is funny that it only fails with python 3.11 🤷‍♂️

@mvdbeek
Copy link
Member Author

mvdbeek commented Aug 17, 2023

I think tox dropped python 3.7 support some time ago, so we're getting a different tox version then. unit-coverage is new-sih, so need to target another branch ...

@jdavcs
Copy link
Member

jdavcs commented Aug 17, 2023

@mvdbeek thanks for fixing this!

@nsoranzo nsoranzo deleted the tox_fix branch August 17, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants